Commit Graph
3 Commits
Author SHA1 Message Date
Adam SmithandClaude Opus 5 30880c0958 fix: restore render_readme; the hacs check fails because the repo is private
Corrects the previous commit, which removed `render_readme` from
hacs.json on a wrong diagnosis. Two errors there:

1. `render_readme` IS in HACS_MANIFEST_JSON_SCHEMA
   (custom_components/hacs/utils/validate.py), so it was never the
   schema violation I claimed, and HacsManifest defaults it to False --
   dropping it would have silently stopped HACS rendering the README on
   the integration's HACS page. Restored.

2. The real cause of both remaining failures is that this repository is
   **private**. hacsjson's error text ("has an invalid 'hacs.json'
   file") is raised on `rawhacsjson is None`, not on a schema error --
   a schema error would surface as a humanized voluptuous message.
   get_hacs_json_raw() fetches
   raw.githubusercontent.com/<repo>/<ref>/hacs.json *unauthenticated*
   (wrapped in @return_none_on_exception), and that 404s for a private
   repo. get_integration_manifest() fetches manifest.json the same way,
   which is why integration_manifest reports "expected a dictionary.
   Got None" -- voluptuous validating None, not a bad manifest. Both
   files are in fact valid and manifest.json already carries all six
   keys INTEGRATION_MANIFEST_JSON_SCHEMA requires.

So these last 2/9 checks cannot pass while the repo is private, and no
repo-side change can fix them; they should clear on their own when it
goes public. The other four failures the previous commit addressed
(topics, description, information, brands) did clear -- confirmed in
run 35296482777, which went 6/9 failed -> 2/9 failed.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NxJYWgGJtCw13qUHZtG8ki
2026-09-17 21:46:16 -04:00
Adam SmithandClaude Opus 5 21702031ff docs: add README and brand icon; drop invalid hacs.json key
The `hacs` validation job has failed on every push since the scaffold
commit (6/9 checks). This fixes the four failures that live in the repo;
the two that live in GitHub metadata (description, topics) are set via
the API and need no commit.

- hacs.json: remove `render_readme`. It is not in the HACS manifest
  schema (valid keys: name, content_in_root, zip_release, filename,
  hide_default_branch, country, homeassistant, hacs,
  persistent_directory), and HACS rejects the whole file on an unknown
  key -- which is what `<Validation hacsjson> failed` was. Expecting
  the cascading `integration_manifest` failure ("expected a dictionary.
  Got None") to clear with it, since manifest.json itself already
  carries every key HACS requires.

- README.md: the repo had none, so the `information` check failed and
  HACS had nothing to render. Documents the one thing this fork adds
  (configurable base URL) and, importantly, the compatibility ceiling:
  upstream calls the Responses API, so an endpoint that only serves
  /v1/chat/completions cannot back the conversation or AI Task
  subentries. Also records which endpoint each subentry needs, that
  upstream's recommended model names and unsupported-model lists are
  OpenAI-specific, the base-URL rules (http/https, no embedded
  credentials, include /v1), and why a blank API key sends the
  `not-required` placeholder.

- brand/icon.png + icon@2x.png: `brands` fails unless the repo ships
  brand assets or the domain is in home-assistant/brands. Shipping
  assets is the option that does not depend on a third-party PR.
  Generated with stdlib zlib/struct (no PIL or ImageMagick in this
  environment) from supersampled SDFs; the generator is scratch, not
  committed. Deliberately neither OpenAI's nor Home Assistant's mark,
  and a placeholder -- replace it with real artwork before release.

Not done here: this fork has no git tag or GitHub release yet. HACS
treats releases as preferred-but-not-required and the action does not
check for one, so it is not part of this failure.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NxJYWgGJtCw13qUHZtG8ki
2026-09-17 21:43:23 -04:00
Adam SmithandClaude Sonnet 5 178d948b1b chore: repo scaffold, Apache-2.0, test harness, CI workflows
Local pytest execution is skipped by owner decision: no release of
pytest-homeassistant-custom-component that pins a Home Assistant
2026.9.x floor installs on Python 3.13 (0.13.317+ requires Python
3.14, which this workstation does not have). requirements_test.txt
is pinned to the correct >=0.13.317 range for CI (Python 3.14) and
files are validated with py_compile instead of a local pytest run.

CI workflows (test.yaml, validate.yaml) moved forward from a later
task since, with local testing gone, CI is the only gate and must
exist before the code it gates.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01739Seac5eMAfNwFeiwV5r4
2026-09-17 17:22:05 -04:00